added code to hide PPON and other based on conditions #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakzal
reviewed
Oct 28, 2024
| { "Other", "Other / None"}, | ||
| { "GB-PPON", "Ppon" } | ||
| }; | ||
| public const string CompaniesHouseNumber = "GB-COH"; |
There was a problem hiding this comment.
Naming is not consistent. “Number” is only used in two cases. Can we drop it to keep scheme naming consistent?
There was a problem hiding this comment.
Done!! renamed to CompanyHouse
There was a problem hiding this comment.
VATNumber suffers the same inconsistency
jakzal
approved these changes
Oct 28, 2024
dharmverma
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.