Bugfix/dp 765 check person not already part of org #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frontend/CO.CDP.OrganisationApp/Pages/Registration/JoinOrganisation.cshtml.cs
Show resolved
Hide resolved
…github.com:cabinetoffice/GCGS-Central-Digital-Platform into bugfix/DP-765-check-person-not-already-part-of-org
andymantell
approved these changes
Oct 25, 2024
jakzal
reviewed
Oct 25, 2024
| { | ||
| throw new PersonAlreadyAddedToOrganisationException( | ||
| $"Person {command.createOrganisationJoinRequestCommand.PersonId} already added to organisation {command.organisationId}."); | ||
| } |
There was a problem hiding this comment.
All these added lines seem to belong together. They accomplish one thing - guard that the person isn't already added. Why not replace all these lines with a single async GuardPersonIsNotAlreadyAdded(organisation, person)?
CheckPersonAlreadyAdded could be just renamed to GuardPersonIsNotAlreadyAdded and throw exception instead of returning a bool.
Outcome: less code, and code in the public method remains on the same level of abstraction.
There was a problem hiding this comment.
@jakzal Thanks for the feedback. Done 👍
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dbgoaco
reviewed
Oct 25, 2024
|
@dbgoaco Did you rebuild everything? |
maciej-goaco
approved these changes
Oct 25, 2024
dharmverma
deleted the
bugfix/DP-765-check-person-not-already-part-of-org
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.