Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-712: Use the DataSource rather than a connection string to configure the database #1088

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

jakzal
Copy link
Member

@jakzal jakzal commented Dec 18, 2024

Cherry-picked from #1075

Also applied in other projects, not only in EntityVerification and Organisation.WebApi.

This is the way that's recommended by npgsql. It will enable us to configure postgres enums properly.

@jakzal jakzal force-pushed the tidying/data-source branch from 57ecd62 to 175ee61 Compare December 18, 2024 22:53
@jakzal jakzal requested a review from dharmverma December 18, 2024 23:02
@jakzal jakzal force-pushed the tidying/data-source branch from 839a452 to bf34438 Compare January 6, 2025 10:03
@jakzal jakzal changed the title Use the DataSource rather than a connection string to configure the database DP-712: Use the DataSource rather than a connection string to configure the database Jan 6, 2025
@shilpigoel-goaco
Copy link
Collaborator

@jakzal shouldn't it be apply to all webapis?

@jakzal
Copy link
Member Author

jakzal commented Jan 6, 2025

@shilpigoel-goaco yes, I thought about it the second i posted it ;)

@jakzal jakzal merged commit 6e13459 into main Jan 6, 2025
9 checks passed
@jakzal jakzal deleted the tidying/data-source branch January 6, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants