Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a config bug with activity_type item not containing a report block. #89

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

caarmen
Copy link
Owner

@caarmen caarmen commented Dec 15, 2024

  • Create a test to reproduce the bug.
  • Fix the bug by falling back to the default report configuration.

@caarmen caarmen changed the base branch from main to issue-83-integration December 15, 2024 17:20
Copy link

github-actions bot commented Dec 15, 2024

File Coverage
All files 97%
logger.py 91%
main.py 97%
settings.py 95%
data/database/connection.py 58%
domain/localrepository/localwithingsrepository.py 94%
domain/usecases/slack/usecase_post_daily_activity.py 95%
domain/usecases/slack/usecase_post_sleep.py 97%
remoteservices/api/withings/subscribeapi.py 87%
remoteservices/api/withings/weightapi.py 95%
remoteservices/repositories/webapifitbitrepository.py 97%
routers/dependencies.py 85%
tasks/fitbitpoll.py 95%
tasks/post_daily_activities_task.py 92%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 1caca63

…it report block defined.

This test current fails. The fix is in the next commit.
We need to use our method to look at the default report block.
@caarmen caarmen changed the title Issue 83 fixes Fix a config bug with activity_type item not containing a report block. Dec 15, 2024
@caarmen caarmen marked this pull request as ready for review December 15, 2024 17:33
@caarmen caarmen merged commit a145658 into issue-83-integration Dec 15, 2024
3 checks passed
@caarmen caarmen deleted the issue-83-fixes branch December 15, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant