Restrict proxy access to known hosts only #10884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inodb
reviewed
Jul 8, 2024
| String[] knownHosts = { | ||
| this.genomeNexusUrl, | ||
| this.genomeNexusGrch38Url, | ||
| "http://mutationaligner.org/api", |
There was a problem hiding this comment.
Looks like it, just to check for existence of this URL:
There was a problem hiding this comment.
We decided to always show the link. See cBioPortal/cbioportal-frontend#4942
inodb
reviewed
Jul 8, 2024
| this.genomeNexusUrl, | ||
| this.genomeNexusGrch38Url, | ||
| "http://mutationaligner.org/api", | ||
| "http://docs.cbioportal.org/news" |
There was a problem hiding this comment.
should we fix cors on the docs site?
There was a problem hiding this comment.
Looks like Github pages now allows CORS! See cBioPortal/cbioportal-frontend#4941
onursumer
force-pushed
the
restrict-proxy-to-known-hosts
branch
from
4a12c8c
to
7376a09
Compare
haynescd
requested changes
Jul 11, 2024
onursumer
force-pushed
the
restrict-proxy-to-known-hosts
branch
from
7376a09
to
8268ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to merge cBioPortal/cbioportal-frontend#4941 and cBioPortal/cbioportal-frontend#4942 before merging this one.