-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alphaMissense in functional impact column #5042
Conversation
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just suggested a few minor changes.
src/shared/components/mutationTable/column/FunctionalImpactColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
src/shared/components/mutationTable/column/FunctionalImpactColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
FunctionalImpactColumnTooltip.siftText()} | ||
{this.state.active === 'polyPhen2' && | ||
FunctionalImpactColumnTooltip.polyPhen2Text()} | ||
{this.state.active === |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use mobx here instead of react state? I think we used to avoid built-in react state in favor of mobx. Not sure if we are still following that practice though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awsome work! Thank you so much for getting this done!
bded945
to
5c7372a
Compare
Add alphaMissense in functional impact column. There are three discrete categories: 'benign', 'pathogenic', or 'ambiguous'. These are derived using the following thresholds: 'benign' if alphamissense_pathogenicity < 0.34; 'pathogenic' if alphamissense_pathogenicity > 0.564; and 'ambiguous' otherwise (category assignments are based on their website)
Test:
link
Add
Functional Impact
column:Hover over AlphaMissense dots, tooltip shows more information:
Download: