Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alphaMissense in functional impact column #5042

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

leexgh
Copy link
Member

@leexgh leexgh commented Nov 13, 2024

Add alphaMissense in functional impact column. There are three discrete categories: 'benign', 'pathogenic', or 'ambiguous'. These are derived using the following thresholds: 'benign' if alphamissense_pathogenicity < 0.34; 'pathogenic' if alphamissense_pathogenicity > 0.564; and 'ambiguous' otherwise (category assignments are based on their website)

Test:

link

Add Functional Impact column:

image

Hover over AlphaMissense dots, tooltip shows more information:

image

Download:

image

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 5c7372a
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/673b612c4253600008c05eeb
😎 Deploy Preview https://deploy-preview-5042.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just suggested a few minor changes.

FunctionalImpactColumnTooltip.siftText()}
{this.state.active === 'polyPhen2' &&
FunctionalImpactColumnTooltip.polyPhen2Text()}
{this.state.active ===
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use mobx here instead of react state? I think we used to avoid built-in react state in favor of mobx. Not sure if we are still following that practice though.

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awsome work! Thank you so much for getting this done!

@inodb inodb added feature and removed enhancement labels Nov 18, 2024
@inodb inodb merged commit 17526f2 into cBioPortal:master Nov 18, 2024
13 of 15 checks passed
@inodb inodb mentioned this pull request Nov 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants