Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ch/10184 support patient filters sent via postdata #4635

Merged
merged 10 commits into from
Jun 7, 2023
Merged

Feature/ch/10184 support patient filters sent via postdata #4635

merged 10 commits into from
Jun 7, 2023

Conversation

haynescd
Copy link
Contributor

@haynescd haynescd commented Jun 2, 2023 •
edited
Loading

Fix cBioPortal/cbioportal#10184

  • Refactored StudyViewQuery extraction ( extracted logic to separate class)
  • Updated StudyViewPage to check if postData has valid filterJson to pass to StudyViewPageStore for filtering

@haynescd haynescd self-assigned this Jun 2, 2023
@haynescd haynescd force-pushed the feature/ch/10184-Support-PatientFilters-Postdata branch from 8761b7d to 137c954 Compare June 2, 2023 16:52
@haynescd haynescd requested a review from alisman June 5, 2023 19:41
@inodb inodb merged commit e9a08df into cBioPortal:master Jun 7, 2023
@haynescd haynescd deleted the feature/ch/10184-Support-PatientFilters-Postdata branch June 28, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisman alisman alisman left review comments

Assignees

@haynescd haynescd

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure that data posted to page can be interpretted as patient filter for studyview
3 participants
@haynescd @alisman @inodb