Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structural variants tab on results view (phase 1) #4588

Merged
merged 8 commits into from
May 9, 2023

Conversation

fuzhaoyuan
Copy link
Contributor

@fuzhaoyuan fuzhaoyuan commented Apr 18, 2023

cBioPortal/cbioportal#10075

Describe changes proposed in this pull request:

Features:

  • Add columns: Mutation Status, Cancer Type Detailed, Annotation
  • Display number of duplicate samples

Refinements:

  • Fulfill features: search Cancer Type Detailed, calculate exons
  • Clean up: fusion bar / pie charts, unused columns
  • Rename: Sample Id -> ID, Annotation -> SV Description
  • Fix: sample link, gene tab switch

@fuzhaoyuan fuzhaoyuan mentioned this pull request Apr 18, 2023
@fuzhaoyuan fuzhaoyuan changed the title Fusion table Fusion table upgrade Apr 18, 2023
@tmazor
Copy link
Contributor

tmazor commented Apr 24, 2023

I'm so excited about this! A few initial comments:

  1. I think we wanted to call the tab 'Structural Variants' rather than 'Fusions'

  2. Also change Fusions to Structural Variants here:
    image

  3. The Mutations tab includes text about duplicate events in patients with multiple samples
    image
    We should have this text for Structural Variants tab too

  4. Filtering doesn't work on the Cancer Type Detailed column, eg filtering for 'prostate' finds nothing here:

image

image

  1. In this query: https://deploy-preview-4588--cbioportalfrontend.netlify.app/results/fusions?cancer_study_list=msk_impact_2017&Z_SCORE_THRESHOLD=2.0&RPPA_SCORE_THRESHOLD=2.0&profileFilter=mutations%2Cstructural_variants%2Ccna&case_set_id=msk_impact_2017_cnaseq&gene_list=EGFR&geneset_list=%20&tab_index=tab_visualize&Action=Submit
    there are a few issues which might be data or might be code, I'm not sure

image

5a) This is probably data, but Event Info should be 'EGFR-intragenic', not 'EGFR-interganic', eg P-0006768-T01-IM5

5b) Both the 'EGFR-Interganic' and 'Deletion of X exons' events should have Gene2=EGFR, eg P-0005539-T01-IM5


const sumReducer = (acc: number, current: number) => acc + current;

return _.chain(this.tableData)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets unit test this logic. put this in a helper function that accepts tableData. perhaps it should accept the flattened array. you can flatten the data outside the function

return visibleColumns.includes(columnType);
}

private binarySearchExonRank = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be unit tested

// A half greater means within intron, then get floored since it's intron rank
return (
<span>
{Number.isInteger(exonRank)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract logic that produces this text into a pure function and unit test it

@fuzhaoyuan fuzhaoyuan force-pushed the fusion-table branch 2 times, most recently from a87bad3 to f66b459 Compare May 8, 2023 13:55
@fuzhaoyuan fuzhaoyuan changed the title Fusion table upgrade Introduce Structural Variant tab with table May 8, 2023
@fuzhaoyuan fuzhaoyuan changed the title Introduce Structural Variant tab with table Structural Variant table May 8, 2023
@alisman alisman added feature skip-changelog Do not show this PR in the release notes and removed feature labels May 9, 2023
@alisman alisman merged commit f8a14ab into cBioPortal:master May 9, 2023
@alisman alisman changed the title Structural Variant table Structural variants tab on results view (phase 1) May 9, 2023
@alisman alisman removed the skip-changelog Do not show this PR in the release notes label May 9, 2023
inodb added a commit to inodb/cbioportal-frontend that referenced this pull request Sep 27, 2023
Remove the feature flag to enable structural variants tab introduced here:

cBioPortal#4588
inodb added a commit to inodb/cbioportal-frontend that referenced this pull request Sep 28, 2023
Remove the feature flag to enable structural variants tab introduced here:

cBioPortal#4588
inodb added a commit that referenced this pull request Sep 29, 2023
Remove the feature flag to enable structural variants tab introduced here:

#4588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants