-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structural variants tab on results view (phase 1) #4588
Conversation
I'm so excited about this! A few initial comments:
5b) Both the 'EGFR-Interganic' and 'Deletion of X exons' events should have Gene2=EGFR, eg P-0005539-T01-IM5 |
src/pages/resultsView/fusion/ResultsViewFusionMapperDataStore.ts
Outdated
Show resolved
Hide resolved
src/pages/resultsView/fusion/ResultsViewFusionMapperDataStore.ts
Outdated
Show resolved
Hide resolved
|
||
const sumReducer = (acc: number, current: number) => acc + current; | ||
|
||
return _.chain(this.tableData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets unit test this logic. put this in a helper function that accepts tableData. perhaps it should accept the flattened array. you can flatten the data outside the function
return visibleColumns.includes(columnType); | ||
} | ||
|
||
private binarySearchExonRank = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be unit tested
// A half greater means within intron, then get floored since it's intron rank | ||
return ( | ||
<span> | ||
{Number.isInteger(exonRank) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract logic that produces this text into a pure function and unit test it
a87bad3
to
f66b459
Compare
Remove the feature flag to enable structural variants tab introduced here: cBioPortal#4588
Remove the feature flag to enable structural variants tab introduced here: cBioPortal#4588
Remove the feature flag to enable structural variants tab introduced here: #4588
cBioPortal/cbioportal#10075
Describe changes proposed in this pull request:
Features:
Refinements: