Impl. study search on Query Page using 'study tags' #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasLee
force-pushed
the
search-study-tags
branch
from
5334c12
to
f022fd9
Compare
pvannierop
changed the title
BasLee
force-pushed
the
search-study-tags
branch
from
5948c3e
to
5a30256
Compare
alisman
reviewed
Apr 17, 2023
alisman
reviewed
Apr 17, 2023
alisman
reviewed
Apr 17, 2023
| allStudyTags.find( | ||
| t => t.studyId === (node as CancerStudy).studyId | ||
| ); | ||
| let studyTags = ''; |
There was a problem hiding this comment.
also, would be nice if we could do null or undefined instead of empty string
alisman
reviewed
Apr 17, 2023
| @@ -252,3 +264,12 @@ export default class CancerStudyTreeData { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| function flattenTags(tags: any): string { | |||
alisman
force-pushed
the
search-study-tags
branch
from
2009473
to
a36e1ca
Compare
alisman
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to search studies on the index page by their study tags.
The study tags are now fetched in the QueryStore, and added to the study node metadata as a flat string.
To search in study tags, the
studyTagsmetadata property is added tosearchNodeFields, so the textQueryUtils includes it when searching.PR depends on this backend PR that adds studyId to the study tags entity.
Changes
DefaultPhraseto more meaningfulStringPhrase(vsListPhrase)defaultNodeFieldstosearchNodeFieldssearchTermsproperty from study list metadata