Added "bar.space" parameter to set space between bars in bar charts #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panthony
force-pushed
the
feat/add-bar-space-option
branch
from
71b4dbd
to
f3fd649
Compare
Current coverage is 63.74% (diff: 100%)@@ dev #1815 diff @@
==========================================
Files 1 1
Lines 4424 4424
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2820 2820
Misses 1604 1604
Partials 0 0
|
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is heavily inspired by #1328.
The difference is that the bar's space is subtracted from the bar's width.
That way the bars container will not be bigger than the container with no space between them.
It also adds some UTs (could be more exhaustive with fixed bar width, bar ratio, though...)