Some fixes for Jupyter Notebook 7 (jupyter#1944)

* Some fixes for Jupyter Notebook 7 * Fix jupyter nbextension * Remove explicit port setting
c3HenryHsieh · Jul 26, 2023 · 9ea3a6c · 9ea3a6c
1 parent 7285848
commit 9ea3a6c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/base-notebook/Dockerfile b/base-notebook/Dockerfile
@@ -125,7 +125,8 @@ RUN set -x && \
         'mamba' \
         'notebook' \
         'jupyterhub' \
-        'jupyterlab' && \
+        'jupyterlab' \
+        'nbclassic' && \
     rm micromamba && \
     # Pin major.minor version of python
     mamba list python | grep '^python ' | tr -s ' ' | cut -d ' ' -f 1,2 >> "${CONDA_DIR}/conda-meta/pinned" && \

diff --git a/docs/using/recipes.md b/docs/using/recipes.md
@@ -486,7 +486,7 @@ docker run -it --rm \
     start.sh jupyter notebook --NotebookApp.token=''
 ```
 
-## Enable nbextension spellchecker for markdown (or any other nbextension)
+## Enable nbclassic-extension spellchecker for markdown (or any other nbclassic-extension)
 
 NB: this works for classic notebooks only
 
@@ -499,7 +499,7 @@ USER ${NB_UID}
 RUN pip install --quiet --no-cache-dir jupyter_contrib_nbextensions && \
     jupyter contrib nbextension install --user && \
     # can modify or enable additional extensions here
-    jupyter nbextension enable spellchecker/main --user && \
+    jupyter nbclassic-extension enable spellchecker/main --user && \
     fix-permissions "${CONDA_DIR}" && \
     fix-permissions "/home/${NB_USER}"
 ```

diff --git a/scipy-notebook/Dockerfile b/scipy-notebook/Dockerfile
@@ -62,7 +62,7 @@ RUN mamba install --quiet --yes \
 # Install facets which does not have a pip or conda package at the moment
 WORKDIR /tmp
 RUN git clone https://github.com/PAIR-code/facets.git && \
-    jupyter nbextension install facets/facets-dist/ --sys-prefix && \
+    jupyter nbclassic-extension install facets/facets-dist/ --sys-prefix && \
     rm -rf /tmp/facets && \
     fix-permissions "${CONDA_DIR}" && \
     fix-permissions "/home/${NB_USER}"