Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need a lock when initializing the context #4

Merged
merged 1 commit into from
Mar 30, 2020
Merged

need a lock when initializing the context #4

merged 1 commit into from
Mar 30, 2020

Conversation

codeboten
Copy link

Without this lock, multiple threads could be trying to set the global runtime context and that would be bad.

NOTE: there might be a more optimal amount of code to lock here.

c24t
c24t approved these changes Mar 30, 2020
View reviewed changes
Copy link
Owner

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codeboten!

opentelemetry-api/src/opentelemetry/context/__init__.py Show resolved Hide resolved
@c24t c24t merged commit c10b76f into c24t:grpc-again Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl left review comments

@c24t c24t c24t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeboten @ocelotl @c24t