Feature/use rapidjson crtalloc #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the default allocator to be CrtAllocator
|
@c-jimenez would greatly appreciate if you can have a look. Most of the changes are from updating rapidjson to the latest current master branch commit This would be great for our usecase, it enables us to use the CrtAllocator by setting the RAPIDJSON_DEFAULT_ALLOCATOR macro This is what I was talking about in #165 |
|
I have tested this for a while on our platform, have not seen any issues with the rapid json update yet |
c-jimenez
changed the base branch from
develop
to
feature/use_rapidjson_crtalloc
c-jimenez
merged commit d280b2c
into
c-jimenez:feature/use_rapidjson_crtalloc
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rapidjson updated to commit: 6089180ecb704cb2b136777798fa1be303618975
https://github.com/Tencent/rapidjson/tree/6089180ecb704cb2b136777798fa1be303618975