Kleisli Composition Operator and Apply_or Added #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the Kleisli composition operator for Option, Result, and CCFun.
c-cube
reviewed
Jul 9, 2024
c-cube
reviewed
Jul 9, 2024
c-cube
reviewed
Jul 9, 2024
Gave up on k_compose for CCFun. Unclear with how to translate function signature into CPS.
Added apply_or for chaining processing functions.
|
Updated PR to remove CCFun changes, added slight documentation to CCFun, and added a new apply_or function. |
NoahBatchelor
changed the title
c-cube
reviewed
Jul 19, 2024
| @@ -111,6 +116,13 @@ let get_or ~default x = | |||
| | None -> default | |||
| | Some y -> y | |||
|
|
|||
| let apply_or f x = | |||
There was a problem hiding this comment.
isn't that fold? edit: oh, no, same default value…
There was a problem hiding this comment.
It was motivated mostly by seeing places where CCString functions were being stringed together, combined with repeated CCOption's get_or to reset back to the original string if the string functions failed. Particularly the operator form would concisely shrink down that sort of pipeline to just the string functions.
Formatting had to be done manually due to mismatching ocamlformat installations.
c-cube
added a commit
to c-cube/opam-repository
that referenced
this pull request
Sep 10, 2024
CHANGES: - predicate combinators: `and_pred` and `or_pred` - feat `pp`: add a bunch of extensions - Kleisli Composition Operator and Apply_or for option/result/fun (c-cube/ocaml-containers#455) - add `CCByte_buffer.to_slice` - add a byte slice type `CCByte_slice` - add `cons_when` to `CCListLabels` - add `(|||>)` and `||>` to `CCFun` - `CCVector`: Add function foldi - add `containers.pvec`, a persistent vector type. - perf: use a monomorphic impl for `CCMonomorphic.{min,max}`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Kleisli composition operator for Option, Result, and CCFun.