use main domain #14
Merged
use main domain #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we always keep a thread alive on the main domain as a worker for new tasks, but other domains can still come and go to manage resources properly in case a pool is started and used only for a short while.
The idea is that you might have APIs that want a runner, but the work is too trivial to require a full actual thread pool. In this case use `No_runner.runner` and calls to `run_async runner f` will turn into `f()`.
now the user can specify `num_threads`; if not provided a sensible default is picked.
c-cube
force-pushed
the
wip-use-main-domain
branch
from
94a0f43 to
64f49b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we allocate n-1 new domains to run pools on, which means the main domain is ignored. However this means a core won't be fully used. This changes the state of things by making the main pool eligible for running worker threads as well.