Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enhance accessor test coverage and helper test coverage #92

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Feature/enhance accessor test coverage and helper test coverage #92

merged 5 commits into from
Oct 26, 2022

Conversation

To-Ki-O
Copy link
Contributor

@To-Ki-O To-Ki-O commented Oct 26, 2022

  • accessor.ts

    • add test which type "dim uninstall" before "dim init" to check the uninstall action without dim.json
    • delete undefined from Union type dimJSON and delete the checks if dimJSON is undefined
  • helper.ts

    • delete the check if the inside of temporary directory is blank

I have already done action comfirmation

  • dim install (from URL)
  • dim install (from dim.json)

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #92 (1368e24) into main (056e3c7) will increase coverage by 1.17%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main       #92      +/-   ##
===========================================
+ Coverage   98.82%   100.00%   +1.17%     
===========================================
  Files          18        18              
  Lines        1282      1261      -21     
  Branches      133       127       -6     
===========================================
- Hits         1267      1261       -6     
+ Misses         15         0      -15     
Impacted Files Coverage Δ
tests/helper.ts 100.00% <ø> (+6.00%) ⬆️
libs/accessor.ts 100.00% <100.00%> (+7.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ryo-ma ryo-ma merged commit 26d0526 into c-3lab:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants