Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/multiple tests #50

Merged
merged 74 commits into from
Sep 5, 2022
Merged

Test/multiple tests #50

merged 74 commits into from
Sep 5, 2022

Conversation

ta-Hirose
Copy link
Contributor

テスト用のコードを作成いたしましたのでご確認よろしくお願いいたします。

y-iimori
y-iimori reviewed Aug 24, 2022
View reviewed changes
tests/libs/install.test.ts Outdated Show resolved Hide resolved
tests/libs/install.test.ts Outdated Show resolved Hide resolved
tests/libs/install.test.ts Outdated Show resolved Hide resolved
tests/libs/install.test.ts Outdated Show resolved Hide resolved
tests/libs/install.test.ts Outdated Show resolved Hide resolved
tests/libs/install.test.ts Outdated Show resolved Hide resolved
tests/libs/install.test.ts Outdated Show resolved Hide resolved
tests/libs/install.test.ts Outdated Show resolved Hide resolved
tests/libs/install.test.ts Outdated Show resolved Hide resolved
tests/libs/install.test.ts Outdated Show resolved Hide resolved
y-iimori
y-iimori reviewed Aug 24, 2022
View reviewed changes
tests/libs/list.test.ts Outdated Show resolved Hide resolved
tests/libs/list.test.ts Outdated Show resolved Hide resolved
Sheile
Sheile reviewed Aug 24, 2022
View reviewed changes
tests/helper.ts Outdated Show resolved Hide resolved
y-iimori
y-iimori reviewed Aug 24, 2022
View reviewed changes
tests/libs/uninstall.test.ts Outdated Show resolved Hide resolved
tests/libs/uninstall.test.ts Outdated Show resolved Hide resolved
tests/libs/uninstall.test.ts Outdated Show resolved Hide resolved
y-iimori
y-iimori reviewed Aug 24, 2022
View reviewed changes
tests/libs/help.test.ts Outdated Show resolved Hide resolved
y-iimori
y-iimori reviewed Aug 24, 2022
View reviewed changes
tests/libs/update.test.ts Outdated Show resolved Hide resolved
tests/libs/update.test.ts Outdated Show resolved Hide resolved
tests/libs/update.test.ts Outdated Show resolved Hide resolved
Sheile
Sheile reviewed Aug 24, 2022
View reviewed changes
tests/libs/help.test.ts Outdated Show resolved Hide resolved
Sheile
Sheile reviewed Aug 24, 2022
View reviewed changes
tests/libs/help.test.ts Outdated Show resolved Hide resolved
Sheile
Sheile reviewed Aug 24, 2022
View reviewed changes
tests/libs/help.test.ts Outdated Show resolved Hide resolved
Sheile
Sheile reviewed Aug 24, 2022
View reviewed changes
tests/libs/install.test.ts Outdated Show resolved Hide resolved
Sheile
Sheile reviewed Aug 24, 2022
View reviewed changes
tests/libs/install.test.ts Outdated Show resolved Hide resolved
Sheile
Sheile reviewed Aug 24, 2022
View reviewed changes
tests/libs/install.test.ts Outdated Show resolved Hide resolved
@ryo-ma
Copy link
Collaborator

ryo-ma commented Aug 25, 2022 •
edited
Loading

テストの全体に対してですが、実際に公開されているデータを使ってテストするのは少々気になりました。
リスクとして以下のようなことが考えられます。

  • 同じデータに対してテストを連続で実行することで対象のサイトに負荷がかかる
  • 対象のデータが公開を辞める可能性がある
  • 対象のデータに更新が入ってしまう可能性がある

テスト用データをリポジトリに含めそこから取得するなどの対応が必要かと思います。

@ta-Hirose ta-Hirose closed this Aug 25, 2022
@ta-Hirose ta-Hirose reopened this Aug 25, 2022
@ta-Hirose ta-Hirose force-pushed the test/multiple-tests branch from 8f020c5 to 00c0821 Compare August 25, 2022 09:26
@Sheile Sheile marked this pull request as ready for review August 31, 2022 11:30
@ryo-ma
Copy link
Collaborator

ryo-ma commented Sep 1, 2022 •
edited
Loading

手元の環境でtestを実行したところいくつかerrorとfailが発生しました。確認いただけますでしょうか。

実行コマンド

$ deno test -A

@y-iimori y-iimori mentioned this pull request Sep 2, 2022
Merged
@ryo-ma ryo-ma merged commit e3d4108 into main Sep 5, 2022
@ta-Hirose ta-Hirose deleted the test/multiple-tests branch September 6, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheile Sheile Sheile left review comments

@TakayasuKoura TakayasuKoura TakayasuKoura left review comments

@y-iimori y-iimori y-iimori left review comments

@k-oizumi-abel k-oizumi-abel k-oizumi-abel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ta-Hirose @ryo-ma @y-iimori @Sheile @TakayasuKoura @k-oizumi-abel