Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back off desync_mitigation_mode to defensive #43

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

joshgubler
Copy link
Member

Setting desync_mitigation_mode to strictest breaks clients that
aren't strictly RFC 7230 compliant (notably, AWS API Gateway).
Setting this attribute to defensive provides sufficent protection
against desync attacks, while still allowing requests from clients
that we can't perfect.
https://en.wikipedia.org/wiki/Robustness_principle

Setting desync_mitigation_mode to strictest breaks clients that
aren't strictly RFC 7230 compliant (notably, AWS API Gateway).
Setting this attribute to defensive provides sufficent protection
against desync attacks, while still allowing requests from clients
that we can't perfect.
https://en.wikipedia.org/wiki/Robustness_principle
Copy link

Plan for Terraform v-1.0.0:

will create 32 resources:

  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - zip_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - docker_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg

see details

Copy link

Plan for Terraform v-0.14.8:

will create 32 resources:

  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - zip_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - docker_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg

see details

Copy link

Plan for Terraform v-0.13.2:

will create 32 resources:

  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - zip_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - docker_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg

see details

@joshgubler joshgubler merged commit f0102c8 into main Jan 18, 2024
5 checks passed
@joshgubler joshgubler deleted the fix-desync-mitigation-mode branch January 18, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants