Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set desync_mitigation_mode to strictest in ALB #39

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Set desync_mitigation_mode to strictest in ALB #39

merged 2 commits into from
Feb 6, 2023

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Feb 6, 2023 •
edited
Loading

desync_mitigation_mode was added in AWS provider v3.67.0. This is a breaking change, because we currently require v3.0.0.

@GaryGSC GaryGSC requested a review from rwinscot February 6, 2023 22:04
@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited
Loading

Plan for Terraform v-1.0.0:

will create 32 resources:

  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - zip_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - docker_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg

see details

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited
Loading

Plan for Terraform v-0.14.8:

will create 32 resources:

  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - zip_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - docker_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg

see details

@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited
Loading

Plan for Terraform v-0.13.2:

will create 32 resources:

  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - zip_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg
  • aws_alb - alb
  • aws_alb_listener - http_to_https
  • aws_alb_listener - https
  • aws_alb_target_group - tg
  • aws_alb_target_group_attachment - live_attachment
  • aws_cloudwatch_log_group - log_group
  • aws_iam_role - iam_for_lambda
  • aws_iam_role_policy_attachment - lambda_cloudwatch_attach
  • aws_iam_role_policy_attachment - lambda_eni_attach
  • aws_lambda_alias - live
  • aws_lambda_function - docker_api
  • aws_lambda_permission - with_lb
  • aws_route53_record - a_record
  • aws_route53_record - aaaa_record
  • aws_security_group - alb-sg
  • aws_security_group - lambda_sg

see details

rwinscot
rwinscot approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@rwinscot rwinscot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous!

@rwinscot rwinscot merged commit 8494ccf into main Feb 6, 2023
@GaryGSC GaryGSC deleted the desync_mitigation_mode branch February 6, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinscot rwinscot rwinscot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaryGSC @rwinscot