Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary types for pino #343

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

sethsmurthwaite
Copy link
Contributor

pino ships with its own type declaration files so we don't need to install them from the @types/pino package

pino ships with its own type declaration files so we don't need to install them from the @types/pino package
@sethsmurthwaite sethsmurthwaite requested a review from a team December 11, 2023 20:29
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f612b1) 72.00% compared to head (07c64bd) 72.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #343   +/-   ##
=======================================
  Coverage   72.00%   72.00%           
=======================================
  Files           2        2           
  Lines          25       25           
  Branches        6        6           
=======================================
  Hits           18       18           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Show resolved Hide resolved
@sethsmurthwaite sethsmurthwaite merged commit 5b43ec8 into main Dec 11, 2023
4 checks passed
@sethsmurthwaite sethsmurthwaite deleted the sethsmurthwaite-patch-1 branch December 11, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants