fix: pdf and evernote failure without title

fixes #48
byteyilabs · Jul 10, 2020 · 3e089fa · 3e089fa
1 parent 37c6215
commit 3e089fa
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/packages/common/services/integration/evernote/generator.js b/packages/common/services/integration/evernote/generator.js
@@ -31,7 +31,9 @@ class Generator {
       `<a style="padding-bottom: 20px;" href="${INSTALLATION_URL}">YiNote</a>`
     )}</span>`;
     nBody += '<br/>';
-    nBody += `<div>${description}</div>`;
+    if (description) {
+      nBody += `<div>${description}</div>`;
+    }
     nBody += '<br/>';
     const resources = [];
     notes.forEach(note => {
@@ -66,7 +68,7 @@ class Generator {
     // Create note object
     const note = new EvernoteSDK.Types.Note();
     note.notebookGuid = notebook.guid;
-    note.title = title;
+    note.title = title || browser.i18n.getMessage('title_default');
     note.content = nBody;
     note.resources = resources;
 

diff --git a/packages/common/services/pdf/index.js b/packages/common/services/pdf/index.js
@@ -42,9 +42,12 @@ export default class PDFGenerator {
     this.doc.setFont('msyh');
     this.doc.setFontType('normal');
     let y = 20;
-    this.doc.setFontSize(18);
-    this.doc.text(20, y, this.doc.splitTextToSize(title, 180));
-    y += Math.ceil(title.length / 50) * 18;
+
+    if (title) {
+      this.doc.setFontSize(18);
+      this.doc.text(20, y, this.doc.splitTextToSize(title, 180));
+      y += Math.ceil(title.length / 50) * 18;
+    }
 
     this.doc.setFontSize(12);
     this.doc.text(20, y, 'Generated from ');

diff --git a/packages/extension/_locales/en/messages.json b/packages/extension/_locales/en/messages.json
@@ -292,5 +292,8 @@
   },
   "star_github": {
     "message": "github.com/shuowu/yi-note"
+  },
+  "title_default": {
+    "message": "Notes sent from YiNote"
   }
-}
+}