c: Use drop-flags when auto-dropping borrows #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Jan 9, 2024
|
Actually I pushed up a fix for that specific issue to this PR so if CI is green I'll merge. |
elliottt
commented
Jan 10, 2024
| let ty = dealias(self.gen.resolve, *id); | ||
|
|
||
| let name = self.locals.tmp("borrow"); | ||
| uwriteln!(self.borrow_decls, "int32_t {name} = 0;"); |
There was a problem hiding this comment.
Is there a better way to refer to the type of a handle here, or is using int32_t directly fine?
There was a problem hiding this comment.
Nah int32_t is fine, I don't think there's anything "more official" at this time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To expand the cases where auto-dropping is possible in wit-bindgen-c, use drop flags to indicate when borrows need to be dropped. This enables us to also auto-drop borrows present in optional and variant types, leaving only lists as the outlier for values that cannot have their borrows automatically dropped.
This implementation takes advantage of
0being a newly reserved resource id, allowing us to use that value to indicate when the borrow wasn't observed during lifting.