Stop formatting ISLE generated code #9901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool stack overflows in default configurations (Windows/CI).
SingleAccretion
requested review from
cfallin
and removed request for
a team
github-actions
bot
added
the
cranelift
cfallin
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Thanks!
Since the discussion on the bug I think I've realized why we had this to begin with: we were originally checking in the generated code to git (and updating when ISLE source changed), so this was likely load-bearing for passing CI formatting checks. Fortunately we don't do that anymore (ISLE-generated Rust is purely a build artifact) so we probably don't have any more reasons we'd want this back. Of course we can always revert if that changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool stack overflows in default configurations (Windows on my machine (tm) / CI).
Example from a recent CI run: https://github.com/bytecodealliance/wasmtime/actions/runs/12472519540/job/34811457587?pr=9897:
Closes #9899.