pulley: Remove unwind metadata from Cranelift backend #9862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a copy/paste from the riscv64 backend originally but there's no need to integrate with native unwinders on Pulley so there's no need to track this information. This removes the `Unwind` pseudo-inst entirely.
cfallin
reviewed
Dec 19, 2024
| @@ -4,7 +4,7 @@ use super::{inst::*, PulleyFlags, PulleyTargetKind}; | |||
| use crate::isa::pulley_shared::{PointerWidth, PulleyBackend}; | |||
| use crate::{ | |||
| ir::{self, types::*, MemFlags, Signature}, | |||
| isa::{self, unwind::UnwindInst}, | |||
| isa::{self}, | |||
There was a problem hiding this comment.
strange artifact not caught by rustfmt maybe? would prefer isa::self to isa::{self}
There was a problem hiding this comment.
oh oops I totally didn't notice this at all!
cfallin
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy/paste from the riscv64 backend originally but there's no need to integrate with native unwinders on Pulley so there's no need to track this information. This removes the
Unwindpseudo-inst entirely.