Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate wasi-keyvalue into wasmtime-cli #9032

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

iawia002
Copy link
Contributor

Continue #8983

This patch adds some new flags:

  -S                                keyvalue[=y|n] -- Enable support for WASI key-value API (experimental)
  -S          keyvalue-in-memory-data=<name>=<val> -- Preset data for the In-Memory provider of WASI key-value API.
  -S                       keyvalue-redis-host=val -- Grant access to the given Redis host for the Redis provider of WASI key-value API.
  -S keyvalue-redis-connection-timeout=N|Ns|Nms|.. -- Sets the connection timeout parameter for the Redis provider of WASI key-value API.
  -S   keyvalue-redis-response-timeout=N|Ns|Nms|.. -- Sets the response timeout parameter for the Redis provider of WASI key-value API.

cc @alexcrichton

@iawia002 iawia002 requested review from a team as code owners July 29, 2024 06:36
@iawia002 iawia002 requested review from alexcrichton and removed request for a team July 29, 2024 06:36
@iawia002 iawia002 force-pushed the cli-wasi-keyvalue branch 2 times, most recently from f91bc36 to 9a0d522 Compare July 29, 2024 07:06
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@alexcrichton alexcrichton added this pull request to the merge queue Jul 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 29, 2024
@iawia002
Copy link
Contributor Author

cargo deny failed due to duplicate socket2 dependency, I believe #9043 solved that issue and I have tested locally, I'll do a rebase after #9043

@alexcrichton alexcrichton added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Jul 30, 2024
Merged via the queue into bytecodealliance:main with commit 12fc764 Jul 30, 2024
38 checks passed
@iawia002 iawia002 deleted the cli-wasi-keyvalue branch July 31, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants