Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cranelift/riscv: refactor rv_fma pattern #8887

Merged
merged 1 commit into from
Jul 3, 2024
Merged

cranelift/riscv: refactor rv_fma pattern #8887

merged 1 commit into from
Jul 3, 2024

Conversation

HerrCai0907
Copy link
Contributor

@HerrCai0907 HerrCai0907 commented Jun 29, 2024 •
edited
Loading

replace if-let with let

@HerrCai0907 HerrCai0907 requested a review from a team as a code owner June 29, 2024 00:41
@HerrCai0907 HerrCai0907 requested review from cfallin and removed request for a team June 29, 2024 00:41
@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Jun 29, 2024
afonso360
afonso360 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@afonso360 afonso360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this somehow slipped off my radar! LGTM, thanks!

@afonso360 afonso360 added this pull request to the merge queue Jul 3, 2024
Merged via the queue into bytecodealliance:main with commit 842fa76 Jul 3, 2024
36 checks passed
@HerrCai0907 HerrCai0907 deleted the refactor/riscv-lower branch July 3, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonso360 afonso360 afonso360 approved these changes

@cfallin cfallin Awaiting requested review from cfallin cfallin is a code owner automatically assigned from bytecodealliance/wasmtime-compiler-reviewers

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HerrCai0907 @afonso360