Respect pooling allocation options in wasmtime serve
#8525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the processing of pooling allocator options in `wasmtime serve`. Previously the pooling allocator was enabled by default but the options to configure it weren't processed due to how this default-enable was implemented. The option to enable it by default for `wasmtime serve`, but only `wasmtime serve`, is now processed differently in a way that handles various other pooling-allocator-related options. Closes bytecodealliance#8504
fitzgen
approved these changes
May 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I've made the decision to ignore the test I've added here with
There's no way to resolve this race with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the processing of pooling allocator options in
wasmtime serve. Previously the pooling allocator was enabled by default but the options to configure it weren't processed due to how this default-enable was implemented. The option to enable it by default forwasmtime serve, but onlywasmtime serve, is now processed differently in a way that handles various otherpooling-allocator-related options.
Closes #8504