-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various tests to pass CI again #785
Conversation
Fixes `path_open_read_without_rights` test making the CI green again.
cc @marmistrz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, sorry and thanks for the swift fix!
No probs! It seems that there were a couple more issues not related to #770 that needed fixing :-) This should now hopefully green the CI again :-) |
Beat you by 4 seconds :) |
Haha, nice one! You get the 🐎 then :-D |
@peterhuene The funny thing is, you've manage to beat not only me but also Github which now reckons you haven't approved the PR even though you did ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
And y'all beat me to uploading my own version of this PR :-}. Thanks for fixing this! |
@sunfishcode There is still chance to collaborate on this PR though. Help with fixing this would be highly appreciated:
|
Looks like a |
Oh, cool. If you point me to the line, I can fix it. Alternatively, if you want to push a commit to this PR , feel free! :-) |
I believe wasmtime/tests/custom_signal_handler.rs Line 107 in 61f9b8a
|
Ah, of course, well spotted! Thanks! |
Trap messages updated! |
@sunfishcode What do you know, now you've beat me to it! :-} |
Merging to unblock CI. |
Fixes
path_open_read_without_rights
test making the CI green again. :-) The bug must have snuck in #770.