Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various tests to pass CI again #785

Merged
merged 4 commits into from
Jan 9, 2020

Conversation

kubkon
Copy link
Member

@kubkon kubkon commented Jan 9, 2020

Fixes path_open_read_without_rights test making the CI green again. :-) The bug must have snuck in #770.

Fixes `path_open_read_without_rights` test making the CI green again.
@kubkon
Copy link
Member Author

kubkon commented Jan 9, 2020

cc @marmistrz

Copy link
Contributor

@marmistrz marmistrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry and thanks for the swift fix!

@kubkon kubkon changed the title Fix path_open_read_without_rights test Fix various tests to pass CI again Jan 9, 2020
@kubkon
Copy link
Member Author

kubkon commented Jan 9, 2020

Whoops, sorry and thanks for the swift fix!

No probs! It seems that there were a couple more issues not related to #770 that needed fixing :-) This should now hopefully green the CI again :-)

@kubkon kubkon requested a review from alexcrichton January 9, 2020 21:06
@kubkon kubkon requested a review from peterhuene January 9, 2020 21:06
@peterhuene
Copy link
Member

Beat you by 4 seconds :)

@kubkon
Copy link
Member Author

kubkon commented Jan 9, 2020

Beat you by 4 seconds :)

Haha, nice one! You get the 🐎 then :-D

@kubkon
Copy link
Member Author

kubkon commented Jan 9, 2020

@peterhuene The funny thing is, you've manage to beat not only me but also Github which now reckons you haven't approved the PR even though you did ;-)

Copy link
Member

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sunfishcode
Copy link
Member

And y'all beat me to uploading my own version of this PR :-}. Thanks for fixing this!

@kubkon
Copy link
Member Author

kubkon commented Jan 9, 2020

@sunfishcode There is still chance to collaborate on this PR though. Help with fixing this would be highly appreciated:

---- tests::test_custom_signal_handler_single_instance stdout ----
memory: base=0x299e9d000, length=65536
calling read...
Hello from instance signal handler!
signal handled: true
calling read_out_of_bounds...
Hello from instance signal handler!
signal handled: false
thread 'tests::test_custom_signal_handler_single_instance' panicked at 'assertion failed: trap.root_cause().to_string().starts_with("trapped: Ref(Trap { message: \"wasm trap: out of bounds memory access")', tests/custom_signal_handler.rs:106:13
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::io::impls::<impl std::io::Write for alloc::boxed::Box<W>>::write_fmt
   4: std::panicking::default_hook::{{closure}}
   5: std::panicking::default_hook
   6: std::panicking::rust_panic_with_hook
   7: std::panicking::begin_panic
   8: custom_signal_handler::tests::test_custom_signal_handler_single_instance
   9: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once
  10: __rust_maybe_catch_panic

@peterhuene
Copy link
Member

Looks like a starts_with assertion needs fixing to the new format (presumably removing Ref().

@kubkon
Copy link
Member Author

kubkon commented Jan 9, 2020

Looks like a starts_with assertion needs fixing to the new format (presumably removing Ref().

Oh, cool. If you point me to the line, I can fix it. Alternatively, if you want to push a commit to this PR , feel free! :-)

@peterhuene
Copy link
Member

I believe Ref( should be removed from this line:

"trapped: Ref(Trap { message: \"wasm trap: out of bounds memory access"

@kubkon
Copy link
Member Author

kubkon commented Jan 9, 2020

I believe Ref( should be removed from this line:

"trapped: Ref(Trap { message: \"wasm trap: out of bounds memory access"

Ah, of course, well spotted! Thanks!

@sunfishcode
Copy link
Member

Trap messages updated!

@kubkon
Copy link
Member Author

kubkon commented Jan 9, 2020

@sunfishcode What do you know, now you've beat me to it! :-}

@peterhuene
Copy link
Member

Merging to unblock CI.

@peterhuene peterhuene merged commit 9ee0544 into bytecodealliance:master Jan 9, 2020
@kubkon kubkon deleted the fix_ci branch January 16, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants