winch(x64): Add support for global get and set #6703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for the `global.set` and `global.get` instructions.
saulecabrera
requested review from
jameysharp
and removed request for
a team and
jameysharp
fitzgen
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Don't see any f32 or f64 globals being tested here. Are those valtypes not supported by winch at all yet? If they are supported, then there should be some exercising of globals of those types. If not, then I guess there should eventually be that same exercising but not in this PR :-p
There was a problem hiding this comment.
Yeah, not supported yet, but I'll be working on introducing support for them next.
github-actions
bot
added
fuzzing
Subscribe to Label Action
This issue or pull request has been labeled: "fuzzing", "winch"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6528
This change adds support for the
global.setandglobal.getinstructions.