fixes to #6462: make wasi-common API compatible with 9.0.1 #6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2023 10:36
required in order to make 9.0.2 a valid patch release.
* `struct FdStat` is public, so I backed out changes to it, and manually
applied the rights bits in the implementation of fd_fdstat_get.
* new `FileAccessMode` changed to be pub(crate), to make sure it doesnt
appear in any pub interfaces. WasiCtx::insert_file and push_file
reverted to their original type signature. Private helper insert_file_
used for the set_{stdio} implementations.
pchickey
force-pushed
the
pch/release-9-wasi-api-compatible
branch
from
0f5e179
to
22292e6
Compare
github-actions
bot
added
wasi
Subscribe to Label Actioncc @kubkon
This issue or pull request has been labeled: "wasi", "wasmtime:docs"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required in order to make 9.0.2 a valid patch release.
struct FdStatis public, so I backed out changes to it, and manually applied the rights bits in the implementation of fd_fdstat_get.new
FileAccessModechanged to be pub(crate), to make sure it doesnt appear in any pub interfaces. WasiCtx::insert_file and push_file reverted to their original type signature. Private helper insert_file_ used for the set_{stdio} implementations.