Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wit-bindgen error types: resolve type definition id by chasing alias ids #6373

Merged
merged 1 commit into from
May 12, 2023

Conversation

pchickey
Copy link
Contributor

TypeInfo's error field is set when a type is used in a _ -> result<_, E> position. When the type is used in another interface, it is given a different identifier. Chase this down to the definition identifier so that the definition is given the error treatment.

@pchickey pchickey requested a review from a team as a code owner May 12, 2023 16:24
@pchickey pchickey requested review from itsrainy and removed request for a team May 12, 2023 16:24
@pchickey pchickey added this pull request to the merge queue May 12, 2023
Merged via the queue into main with commit a729a2a May 12, 2023
@pchickey pchickey deleted the pch/error_fixes branch May 12, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants