Use new WasiCtxBuilder types from wasi-common
#490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gah, I think this is going to be broken until I can specify the right wasi-common revision, which will in turn change the revision I need to specify in my wasi-common PR, which ... Since wasi-common only depends on this repo for tests, I think it makes sense to wait until/if that PR gets merged, and then fix things up over here. |
sunfishcode
approved these changes
Nov 7, 2019
kubkon
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates uses of the
WasiCtxBuildertype to be compatible with the changes I have proposed in CraneStation/wasi-common#175. Unless/until that has merged, these changes don't make sense, so I'm marking this as a draft PR.