-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SignalHandlers.h to SignalHandlers.hpp #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change looks good, thanks! That said, it's not obvious to me why this fixes #41, since <stdbool.h> is a C header file which ought to be available to C code. |
kubkon
pushed a commit
that referenced
this pull request
Nov 7, 2019
* Implement fd_filestat_get for all platforms * Remove an old comment * Remove panics from the syscall wrappers * Return WASI error type * Reuse Metadata if possible to save syscalls. * Refactor the change for two separate fd_filestat_get_impl * Refactor error handling
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
* Initial implementation * Not use grow as it is makes debug builds very slow * Use Pages::BYTE_SIZE for LINEAR_MEMORY_PAGE_SIZE * Tidy docs. * Use memory_units from git.
howjmay
pushed a commit
to howjmay/wasmtime
that referenced
this pull request
Jan 24, 2022
The global map for storing `*Func` objects previously stored `*Store`, but that creates a reference cycle between the Rust and the Go heaps which can't be cleaned up. Instead this commit updates the logic to instead use a "thread local" variable to temporarily store the current freelist during a call and moves the storage outside of the global variables. This should allow everything to get garbage collected as usual. Closes bytecodealliance#42
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 16, 2023
This gets us another step closer to running the Wasmtime tests.
dhil
pushed a commit
to dhil/wasmtime
that referenced
this pull request
Jul 13, 2023
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Jul 13, 2023
This patch improves upon bytecodealliance#42. In addition it renames the flag, so to build a compiler & runtime without linearity checking one has to supply the following: ```shell $ cargo build --features=default,unsafe_disable_continuation_linearity_check ```
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Jul 13, 2023
This patch improves upon bytecodealliance#42. In addition it renames the flag, so to build a compiler & runtime without linearity checking one has to supply the following: ```shell $ cargo build --features=default,unsafe_disable_continuation_linearity_check ```
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Jul 13, 2023
bytecodealliance#47) * Improve compile option for disabling the continuation linearity check. This patch improves upon bytecodealliance#42. In addition it renames the flag, so to build a compiler & runtime without linearity checking one has to supply the following: ```shell $ cargo build --features=default,unsafe_disable_continuation_linearity_check ```
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Nov 3, 2023
…odealliance#42) This patch is a follow up on PR bytecodealliance#35. It partially addresses issue presence of stack switching as older frame pointers are not guaranteed to be greater than the current frame pointer (e.g. tracing across stack boundaries).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41