Update Table::grow's return to be the previous size
#1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings it in line with `Memory::grow` and the `table.grow` instruction which return the size of the table previously, not the size of the table currently.
github-actions
bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
peterhuene
approved these changes
May 5, 2020
peterhuene
reviewed
May 5, 2020
| @@ -46,7 +46,8 @@ impl Table { | |||
| /// Returns `None` if table can't be grown by the specified amount | |||
| /// of elements. | |||
| pub fn grow(&self, delta: u32) -> Option<u32> { | |||
| let new_len = match self.size().checked_add(delta) { | |||
| let size = self.size(); | |||
There was a problem hiding this comment.
Nit: should we document what this function returns in the Some case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings it in line with
Memory::growand thetable.growinstruction which return the size of the table previously, not the size
of the table currently.