Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception and control tags #10251

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Exception and control tags #10251

merged 7 commits into from
Feb 20, 2025

Conversation

dhil
Copy link
Contributor

@dhil dhil commented Feb 20, 2025

This patch is a subset of PR #10177. It adds support for tags in Wasmtime. Tags are used by the exception handling and stack switching proposals for typing and matching transfers of control.

This patch does not implement component model or C API support for tags. Issue #10252 tracks these two things.

CC @frank-emrich

@dhil dhil requested a review from a team as a code owner February 20, 2025 14:54
@dhil dhil requested review from alexcrichton and removed request for a team February 20, 2025 14:54
@github-actions github-actions bot added fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API. wasmtime:config Issues related to the configuration of Wasmtime wasmtime:ref-types Issues related to reference types and GC in Wasmtime labels Feb 20, 2025
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:c-api", "wasmtime:config", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing, wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for being willing to split up the PR, it's very helpful!

Comment on lines +1085 to +1088
// FIXME(dhil): Once the config provides a handle
// for turning on/off exception handling proposal support,
// this ought to only enable stack switching.
self.wasm_feature(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a "miscellaneous TODO items" section on #10248 and added this there too (trying to ensure FIXME's like this are written down in issues)

@alexcrichton alexcrichton added this pull request to the merge queue Feb 20, 2025
Merged via the queue into bytecodealliance:main with commit 0b4c754 Feb 20, 2025
41 checks passed
@dhil dhil deleted the tags branch February 20, 2025 17:01
@dhil
Copy link
Contributor Author

dhil commented Feb 20, 2025

Thank you again for being willing to split up the PR, it's very helpful!

My pleasure! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:c-api Issues pertaining to the C API. wasmtime:config Issues related to the configuration of Wasmtime wasmtime:ref-types Issues related to reference types and GC in Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants