Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASI: vague description of __wasi_random_get() #72

Closed
npmccallum opened this issue Mar 27, 2019 · 2 comments
Closed

WASI: vague description of __wasi_random_get() #72

npmccallum opened this issue Mar 27, 2019 · 2 comments
Labels
wasi:api Issues pertaining to the WASI API, not necessarily specific to Wasmtime.

Comments

@npmccallum
Copy link
Member

  1. Does this API intend to provide random data suitable for use in cryptography?
  2. Does this API block if the system currently cannot provide sufficient entropy or does it return degraded randomness?
@sunfishcode sunfishcode added the wasi:api Issues pertaining to the WASI API, not necessarily specific to Wasmtime. label Mar 27, 2019
@sunfishcode
Copy link
Member

Good questions :-).

random_get is roughly meant to align with getentropy, which is non-standard, but available on a variety of systems. It returns "high-quality" random data, in the sense that getentropy man pages intend that phrase.

And, it can block, as getentropy can. I've now added a sentence to the documentation mentioning that.

That said, I can easily believe there's room for improvement here :-).

@sunfishcode
Copy link
Member

The API has been updated to answer these questions!

howjmay pushed a commit to howjmay/wasmtime that referenced this issue Jan 24, 2022
pchickey pushed a commit to pchickey/wasmtime that referenced this issue May 12, 2023
This commit fixes the non-command build of the WASI adapter by adding a
new `wasi.wit` which only has the imports and nothing else.
frank-emrich pushed a commit to frank-emrich/wasmtime that referenced this issue Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasi:api Issues pertaining to the WASI API, not necessarily specific to Wasmtime.
Projects
None yet
Development

No branches or pull requests

2 participants