Update magnus 0.6.0 [Attempt #2] #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome stuff. Don't worry about the windows test failures for now, I'll see what I can do about that (it's not from this PR). |
1 similar comment
|
Awesome stuff. Don't worry about the windows test failures for now, I'll see what I can do about that (it's not from this PR). |
Youssef-Mak
force-pushed
the
update-magnus
branch
from
2d7394b to
945ea3c
Compare
typed_data::Obj now derefs to the wrapped data, so get() is unnecessary
Youssef-Mak
force-pushed
the
update-magnus
branch
from
945ea3c to
209135b
Compare
Youssef-Mak
force-pushed
the
update-magnus
branch
2 times, most recently
from
f40fd40 to
cec85a5
Compare
Youssef-Mak
force-pushed
the
update-magnus
branch
from
d447b94 to
f0cbd39
Compare
|
Taking a look now |
|
Superseded by #205 which I just merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.