[wasm-metadata] pretty-print cli output #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
force-pushed
the
metadata-pretty-print-table
branch
from
9ae4ab4 to
9926452
Compare
|
Ok, this should be good to review now! |
|
updated with feedback from review! |
alexcrichton
approved these changes
Dec 10, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1923. While this doesn't quite deliver on the vision I sketched in the issue, I believe it's a meaningful step up from the status quo. I've also filed Nukesor/comfy-table#160, which if accepted will hopefully allow us to more closely match
duf's output.I'm not quite sure what the process for introducing new dependencies here is. To pretty-print tables, we're going to need some printing library - and
comfy-tableseemed like a reasonable choice. I looked at the deps, and nothing particularly stood out to me as a potential problem?Thanks!
Screenshot
This is what the output currently looks like. I might do another pass to add colors, etc - but this seemed like a good starting point.