Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmparser: fix crate feature propagation #1902

Merged

Conversation

Robbepop
Copy link
Collaborator

@Robbepop Robbepop commented Nov 11, 2024

No longer enable indexmap and hashbrown when std feature is enabled without hash-collections feature.

@Robbepop
Copy link
Collaborator Author

The fuzz job fails with

error: toolchain 'nightly-x86_64-unknown-linux-gnu' does not support target 'wasm32-wasi'; did you mean 'wasm32-wasip1'?

Seems to be unrelated to this PR.

@alexcrichton
Copy link
Member

Thanks! Mind rebasing to pick up the fix from #1901?

@Robbepop Robbepop force-pushed the rf-fix-crate-feature-propagation branch from afaa424 to 60136c1 Compare November 12, 2024 05:38
@Robbepop
Copy link
Collaborator Author

Thanks! Mind rebasing to pick up the fix from #1901?

Done :)

auto-merge was automatically disabled November 12, 2024 05:46

Head branch was pushed to by a user without write access

@Robbepop
Copy link
Collaborator Author

@alexcrichton It seems wasm-metadata strictly requires the hash-collections crate feature from the wasmparser crate. I had to enable it to make wasm-metadata compile again.

@alexcrichton alexcrichton added this pull request to the merge queue Nov 12, 2024
Merged via the queue into bytecodealliance:main with commit 5752b1c Nov 12, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants