Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the comments for hexadecimal float parsing. #1888

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Improve the comments for hexadecimal float parsing. #1888

merged 2 commits into from
Oct 31, 2024

Conversation

sunfishcode
Copy link
Member

Replace the comments requesting better comments with better comments, and tidy up the code.

@sunfishcode
Improve the comments for hexadecimal float parsing.
471dbf5 
Replace the comments requesting better comments with better comments,
and tidy up the code.
@sunfishcode
Fix a typo.
13be0a1
alexcrichton
alexcrichton approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@alexcrichton alexcrichton added this pull request to the merge queue Oct 31, 2024
Merged via the queue into bytecodealliance:main with commit 6a76d04 Oct 31, 2024
30 checks passed
@sunfishcode sunfishcode deleted the sunfishcode/hex-floats branch October 31, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunfishcode @alexcrichton