Fix generating shims with duplicate names #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with the semver-merging logic of `wit-component` where during the componentization process due to insertion-with-replacement behavior the same name could be assigned to two different shims (as shim names are based on the map length which wouldn't change if a replacement was inserted). The fix in this commit is to avoid replacement and prefer the original name when a shim is inserted. Closes bytecodealliance#1850
alexcrichton
force-pushed
the
fix-duplicate-exports
branch
from
1a6ea47 to
95da54a
Compare
dicej
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the semver-merging logic of
wit-componentwhere during the componentization process due toinsertion-with-replacement behavior the same name could be assigned to two different shims (as shim names are based on the map length which wouldn't change if a replacement was inserted). The fix in this commit is to avoid replacement and prefer the original name when a shim is inserted.
Closes #1850