Add a component-model feature to wat/wast/wasm-encoder
#1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case folks depend on these crates but aren't interested in the component support this enables compiling it all out.
If users are interested it can be used to reduce the compile-time of the crate and amount of code brought in by removing much of it at compile time. Support remains enabled by default, however.
fitzgen
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I case users want to disable the component model proposal this can be useful to cut down on both binary size and compilation time of these crates themselves. Additionally this helps keep component bits more cleanly separable from the rest of the various bits. Note that the component-model features remains on-by-default.