Protect wasm-smith against arbitrary Config differently
#1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `Arbitrary for Config` will perform some internal validation of options, such as if reference-types are disabled then gc is also disabled. This validation doesn't happen for other sources of `Config` though, such as CLI options or from manual configuration. This commit moves these checks from `Arbitrary for Config` to unconditionally happening during module creation. This fixes a panic where if reference types are disabled but tables are allowed then an internal assertion was tripped because GC types were used when they shouldn't be.
fitzgen
approved these changes
Sep 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Arbitrary for Configwill perform some internal validation of options, such as if reference-types are disabled then gc is also disabled. This validation doesn't happen for other sources ofConfigthough, such as CLI options or from manual configuration. This commit moves these checks fromArbitrary for Configto unconditionally happening during module creation. This fixes a panic where if reference types are disabled but tables are allowed then an internal assertion was tripped because GC types were used when they shouldn't be.