json-from-wast: Include binary form of text files where possible #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Sep 10, 2024
The very large diffs from errors in development bytecodealliance#1775 caused OOMs so I figured now's as good a time as any to switch over to using `pretty_assertions` which other crates in the workspace are already using.
This commit is aimed at addressing bytecodealliance#1771 by including a new `binary_filename` field in the JSON which is populated when the test itself is `module quote`, or a textual module, but the module parse successfully. This should help avoid the need for a text parser for external users using the tool while still reflecting the test case itself where it's text-based. Closes bytecodealliance#1771
alexcrichton
force-pushed
the
include-binary-form
branch
from
0996998 to
f9deebd
Compare
|
Looks like Windows was stack overflowing due to an invalid module being encoded. The invalid module stack overflows in debug mode but presents a first-class error in release mode. Instead of going too deep into fixing that I've updated this to skip |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
The very large diffs from errors in development #1775 caused OOMs so I figured now's as good a time as any to switch over to using `pretty_assertions` which other crates in the workspace are already using.
fitzgen
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is aimed at addressing #1771 by including a new
binary_filenamefield in the JSON which is populated when the test itself ismodule quote, or a textual module, but the module parse successfully. This should help avoid the need for a text parser for external users using the tool while still reflecting the test case itself where it's text-based.Closes #1771