Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-std builds for MacOS and BSDs #647

Merged
merged 2 commits into from
Apr 30, 2023

Conversation

niluxv
Copy link
Contributor

@niluxv niluxv commented Apr 30, 2023

Now to my knowledge all targets except windows compile fine for no-std again.

@niluxv
Copy link
Contributor Author

niluxv commented Apr 30, 2023

That CI failure seems unrelated to my changes:

 error: variable does not need to be mutable
   --> src/net/send_recv/msg.rs:171:13
    |
171 |         let mut last_header = leap!(messages::Messages::new(buffer).last());
    |             ----^^^^^^^^^^^
    |             |
    |             help: remove this `mut`
    |
    = note: `-D unused-mut` implied by `-D warnings`

I guess I can fix it though (last_header doesn't need to be mutable, since it is an &mut reference, and only the pointed-to place needs to be mutated).

@niluxv niluxv closed this Apr 30, 2023
@niluxv niluxv reopened this Apr 30, 2023
@sunfishcode
Copy link
Member

Thanks!

@sunfishcode sunfishcode merged commit 7f4c3fe into bytecodealliance:main Apr 30, 2023
@sunfishcode
Copy link
Member

This is now released in rustix 0.37.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants