Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use RUSTC_WRAPPER when non empty #565

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

markdingram
Copy link
Contributor

We have a build that sets RUSTC_WRAPPER to either sccache or empty string -> after latest release it is now failing on the empty string case.

https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-reads suggests this should be acceptable:

Setting this to the empty string overwrites the config and resets cargo to not use a wrapper.

Thanks!

@sunfishcode
Copy link
Member

Thanks!

@sunfishcode sunfishcode merged commit d2d93e0 into bytecodealliance:main Mar 20, 2023
sunfishcode added a commit to sunfishcode/io-lifetimes that referenced this pull request Mar 20, 2023
sunfishcode added a commit to bytecodealliance/cap-std that referenced this pull request Mar 20, 2023
sunfishcode added a commit to sunfishcode/io-lifetimes that referenced this pull request Mar 20, 2023
sunfishcode added a commit to bytecodealliance/cap-std that referenced this pull request Mar 20, 2023
sunfishcode pushed a commit that referenced this pull request Mar 20, 2023
Co-authored-by: Mark Ingram <mark.ingram@anaplan.com>
sunfishcode added a commit to bytecodealliance/cap-std that referenced this pull request Mar 20, 2023
@sunfishcode
Copy link
Member

This is now released in 0.37.3 and 0.36.11.

sunfishcode added a commit to bytecodealliance/cap-std that referenced this pull request Mar 28, 2023
sunfishcode added a commit to bytecodealliance/cap-std that referenced this pull request Mar 28, 2023
sunfishcode pushed a commit that referenced this pull request Oct 12, 2023
Co-authored-by: Mark Ingram <mark.ingram@anaplan.com>
sunfishcode pushed a commit that referenced this pull request Oct 12, 2023
Co-authored-by: Mark Ingram <mark.ingram@anaplan.com>
sunfishcode pushed a commit that referenced this pull request Oct 12, 2023
Co-authored-by: Mark Ingram <mark.ingram@anaplan.com>
sunfishcode pushed a commit that referenced this pull request Oct 12, 2023
Co-authored-by: Mark Ingram <mark.ingram@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants