This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
Don't use non-constant string as panic!()'s first argument #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These aren't strings, they're values that we use with We should get rid of that semicolon, though 🙂 |
This is no longer accepted in Rust 2021 Also remove a column sign after a function definition (how come that did even compile?)
jedisct1
force-pushed
the
fdenis/dont-panic-42
branch
from
188fda6 to
f4a4109
Compare
|
Thanks! I guess we have to wait for the next release and use |
|
Ah yes, looks like it! I didn't know about that API change. Thanks for keeping eyes out for us |
|
Correct link to the issue: rust-lang/rust#78500 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer accepted in Rust 2021.
Also remove a column sign after a function definition (how come that did even compile?)