Fix compilation errors on Rust nightly. #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation errors that started appering on Rust nightly. This
appears to just need an explicit dereference where one was not
previously needed.
An example of the error message is:
```
error[E0308]: mismatched types
--> cap-primitives/src/fs/via_parent/rename.rs:22:58
|
22 | let (old_dir, old_basename) = open_parent(old_start, &old_path)?;
| ^^^^^^^^^ expected struct `Path`, found opaque type
|
::: cap-primitives/src/rustix/fs/dir_utils.rs:67:48
|
67 | pub(crate) fn strip_dir_suffix(path: &Path) -> impl Deref<Target = Path> + '_ {
| ------------------------------ the found opaque type
|
= note: expected struct `Path`
found opaque type `impl Deref<Target = Path>`
```
|
Merging this trivial change so that we can get an update out to fix build breakage. |
sunfishcode
added a commit
to sunfishcode/wasmtime
that referenced
this pull request
Feb 9, 2022
Other than doc updates, this just contains bytecodealliance/cap-std#235, a fix for compilation errors on Rust nightly that look like this: ``` error[E0308]: mismatched types --> cap-primitives/src/fs/via_parent/rename.rs:22:58 | 22 | let (old_dir, old_basename) = open_parent(old_start, &old_path)?; | ^^^^^^^^^ expected struct `Path`, found opaque type | ::: cap-primitives/src/rustix/fs/dir_utils.rs:67:48 | 67 | pub(crate) fn strip_dir_suffix(path: &Path) -> impl Deref<Target = Path> + '_ { | ------------------------------ the found opaque type | = note: expected struct `Path` found opaque type `impl Deref<Target = Path>` ```
sunfishcode
added a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Feb 10, 2022
Other than doc updates, this just contains bytecodealliance/cap-std#235, a fix for compilation errors on Rust nightly that look like this: ``` error[E0308]: mismatched types --> cap-primitives/src/fs/via_parent/rename.rs:22:58 | 22 | let (old_dir, old_basename) = open_parent(old_start, &old_path)?; | ^^^^^^^^^ expected struct `Path`, found opaque type | ::: cap-primitives/src/rustix/fs/dir_utils.rs:67:48 | 67 | pub(crate) fn strip_dir_suffix(path: &Path) -> impl Deref<Target = Path> + '_ { | ------------------------------ the found opaque type | = note: expected struct `Path` found opaque type `impl Deref<Target = Path>` ```
mpardesh
pushed a commit
to avanhatt/wasmtime
that referenced
this pull request
Mar 17, 2022
…odealliance#3786) Other than doc updates, this just contains bytecodealliance/cap-std#235, a fix for compilation errors on Rust nightly that look like this: ``` error[E0308]: mismatched types --> cap-primitives/src/fs/via_parent/rename.rs:22:58 | 22 | let (old_dir, old_basename) = open_parent(old_start, &old_path)?; | ^^^^^^^^^ expected struct `Path`, found opaque type | ::: cap-primitives/src/rustix/fs/dir_utils.rs:67:48 | 67 | pub(crate) fn strip_dir_suffix(path: &Path) -> impl Deref<Target = Path> + '_ { | ------------------------------ the found opaque type | = note: expected struct `Path` found opaque type `impl Deref<Target = Path>` ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation errors that started appering on Rust nightly. This
appears to just need an explicit dereference where one was not
previously needed.
An example of the error message is: