Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround pathlib glob not supporting dir symlinks, use tdewolff-minify instead of htmlmin2 #38

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

evan-flynn-apexai
Copy link

@evan-flynn-apexai evan-flynn-apexai commented Feb 7, 2024

  1. Pathlib glob does not include files from directories that are symlinked for Python <3.13, work-around is to just use glob.glob instead with the recursive=True flag set
  2. Migrate to use tdewolff-minify instead of htmlmin2

evan-flynn-apexai and others added 2 commits February 6, 2024 14:18
pathlib glob for Python <3.12 does not glob over directories that are symlinked. Instead, work around is to use `glob.glob` that does
Signed-off-by: Evan Flynn <evan.flynn@apex.ai>
@takase1121
Copy link

Hey, I replaced jsmin with tdewolff/minify as well in my own branch:
https://github.com/takase1121/mkdocs-minify-plugin/tree/workaround-pathlib-glob-not-supporting-dir-symlinks

It seems to work well and minifies JS better too since it can uglify them.

@navidbehnam
Copy link

Hey, I replaced jsmin with tdewolff/minify as well in my own branch:
https://github.com/takase1121/mkdocs-minify-plugin/tree/workaround-pathlib-glob-not-supporting-dir-symlinks

It seems to work well and minifies JS better too since it can uglify them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perhaps try tdewolff/minify?
3 participants