Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Go workspaces when running the bingo commands #117

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

nacx
Copy link
Contributor

@nacx nacx commented Jul 12, 2022

When using Go workspaces with Go 1.18, bingo fails with errors like:

(re)installing /Users/nacx/go/bin/goimports-v0.1.5
go: -mod may only be set to readonly when in workspace mode, but it is set to "mod"
	Remove the -mod flag to use the default readonly value,
	or set GOWORK=off to disable workspace mode.
make: *** [/Users/nacx/src/ngac/scripts//../.bingo/Variables.mk:30: /Users/nacx/go/bin/goimports-v0.1.5] Error 1

This PR always sets the GOWORK=off environment variable to disable workspaces for the Bingo commands. This should be safe as Bingo is scoped to its own folder and does not affect the normal project build.

Copy link
Owner

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Amazing 💪🏾

@bwplotka bwplotka merged commit bc83849 into bwplotka:main Aug 2, 2022
@nacx nacx deleted the workspaces branch August 2, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants